[PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init
From: Humberto Silva Naves <hidden>
Date: 2014-07-31 11:23:42
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
Subsystem:
common clk framework, samsung soc clock drivers, the rest · Maintainers:
Michael Turquette, Stephen Boyd, Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi, Linus Torvalds
Added NULL pointer checks for device_node input parameter and for the samsung_clk_provider context returned by samsung_clk_init. Even though the *current* samsung_clk_init function never returns a NULL pointer, it is good to keep this check in place to avoid possible problems in the future due to changes in implementation. That way, we also improve the consistency of the code that performs clock initialization across the different SoCs. Signed-off-by: Humberto Silva Naves <redacted> --- drivers/clk/samsung/clk-exynos5410.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5410.c b/drivers/clk/samsung/clk-exynos5410.c
index 231475b..bf57c80 100644
--- a/drivers/clk/samsung/clk-exynos5410.c
+++ b/drivers/clk/samsung/clk-exynos5410.c@@ -188,11 +188,17 @@ static void __init exynos5410_clk_init(struct device_node *np) struct samsung_clk_provider *ctx; void __iomem *reg_base; - reg_base = of_iomap(np, 0); - if (!reg_base) - panic("%s: failed to map registers\n", __func__); + if (np) { + reg_base = of_iomap(np, 0); + if (!reg_base) + panic("%s: failed to map registers\n", __func__); + } else { + panic("%s: unable to determine soc\n", __func__); + } ctx = samsung_clk_init(np, reg_base, CLK_NR_CLKS); + if (!ctx) + panic("%s: unable to allocate context.\n", __func__); samsung_clk_register_pll(ctx, exynos5410_plls, ARRAY_SIZE(exynos5410_plls), reg_base);
--
1.7.10.4