Re: [PATCH/RFC v4 02/21] leds: implement sysfs interface locking mechanism
From: Sakari Ailus <sakari.ailus@iki.fi>
Date: 2014-07-16 15:36:01
Also in:
linux-leds, linux-media, lkml
Hi Jacek, Thank you for the update! Jacek Anaszewski wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 71b40d3..4d7cb31 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c@@ -126,3 +126,21 @@ void led_set_brightness(struct led_classdev *led_cdev, __led_set_brightness(led_cdev, brightness); } EXPORT_SYMBOL(led_set_brightness); + +/* Caller must ensure led_cdev->led_lock held */ +void led_sysfs_lock(struct led_classdev *led_cdev) +{ + WARN_ON(!mutex_is_locked(&led_cdev->led_lock));
How about lockdep_assert_held() instead? -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk