Re: [PATCH v2] pinctrl: msm: Add msm8960 definitions

On Tue, Jun 24, 2014 at 5:17 PM, Andreas Färber [off-list ref] wrote:

Am 24.06.2014 20:16, schrieb Bjorn Andersson:

quoted

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt
new file mode 100644
index 0000000..6e79eea
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt

[...]

quoted

+Example:
+
+     msmgpio: pinctrl@800000 {
+             compatible = "qcom,msm8960-pinctrl";
+             reg = <0x800000 0x4000>;
+
+             gpio-controller;
+             #gpio-cells = <2>;
+             interrupt-controller;
+             #interrupt-cells = <2>;
+                interrupts = <0 32 0x4>;

This line seems space-indented while surrounding ones are tab-indented.

Thanks, not only is it incorrectly indented, it's also a bad example
as it's the wrong IRQ for msm8960...

quoted

+
+             pinctrl-names = "default";
+             pinctrl-0 = <&debug_uart>;
+
+             debug_uart: debug_uart {

While at it, might debug-uart be a better node name? That seems the
predominant convention and distinguishes from the label.

You're right and reference design does not use gsbi8 as uart, so I'll update it.

Thanks for the review.

Regards,
Bjorn