Re: [PATCH v4 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes

quoted

quoted

    Hm, are you sure about that? I thought only PCI devices should have it...

quoted

Yes, pretty sure it's needed in both the host controller and the
devices.

    I don't understand the case of the PCI devices, honestly.
Shouldn't the "device_type" prop reflect the device's functionality
rather than the bus where it's located?

It is confusingly named, but it is required on the host bridge OF node.

The spec says ' .. corresponding to a device that implements a PCI bus',
which includes the host bridge.

The key element is that it must be present on the node that introduces
the PCI 3 dword address encoding scheme, and then on all nodes below
it that use the 3 dword scheme.

Otherwise Linux common OF PCI code does not work properly.

Jason