Re: [PATCH v5 3/3] ASoC: fsl: add imx-es8328 machine driver

On Fri, Jun 20, 2014 at 02:14:19PM +0800, Sean Cross wrote:

+  ES8328 pins:
+   * LOUT1
+   * LOUT2
+   * ROUT1
+   * ROUT2

These should be covered in the binding document for the CODEC.

+	/* Setup clocks */
+	data->codec_clk = devm_clk_get(dev, NULL);
+	if (IS_ERR(data->codec_clk)) {
+		dev_err(dev,
+			"codec clock missing or invalid\n");
+		goto fail;
+	}
+
+	ret = clk_prepare_enable(data->codec_clk);
+	if (ret) {
+		dev_err(data->dev, "unable to prepare codec clk\n");
+		return ret;
+	}

The CODEC driver should manage the clock for the CODEC, if it's mapped
properly attempting to look it up using the card device should fail.