Re: [PATCH 1/2] media: mt9m111: add device-tree suppport
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2014-06-19 19:15:22
Also in:
linux-media
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2014-06-19 19:15:22
Also in:
linux-media
Guennadi Liakhovetski [off-list ref] writes:
Hi Robert,quoted
+static int of_get_mt9m111_platform_data(struct device *dev, + struct soc_camera_subdev_desc *desc) +{ + return 0; +}Why do you need this function? I would just drop it.
Yeah, drop it sounds good. I wrote it at the beginning to have a clear structure, and then didn't use it.
quoted
+static const struct of_device_id mt9m111_of_match[] = { + { .compatible = "micron,mt9m111", },Not a flaw in this patch, but someone might want to add "micron" to Documentation/devicetree/bindings/vendor-prefixes.txt
OK, I'll see what I can submit, it should be doable :) Cheers. -- Robert