Re: [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding

On Mon, Jun 16, 2014 at 03:35:20PM -0600, Stephen Warren wrote:

On 06/16/2014 08:57 AM, Thierry Reding wrote:

quoted

From: Thierry Reding <redacted>

This patch adds the device tree binding documentation for the XUSB pad
controller found on NVIDIA Tegra SoCs. It exposes both pinmuxing and PHY
capabilities.

This looks fine to me, with one issue below:

quoted

diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt

quoted

+Required properties:
+--------------------

quoted

+- #address-cells: Should be 0.
+- #size-cells: Should be 0.

I don't think those properties are needed. If they are, a value of 0 for
both doesn't seem useful. I assume those two lines should just be
deleted, and also from the example below.

Assuming I take this through the Tegra tree, If this is the only issue,
I can delete those lines when applying.

I've just sent a v4 including these changes along with a fix for the bug
that Mikko pointed out.

Thierry