Re: [RESEND2 PATCH v4 2/2] i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) controller support

Hello Paul,

On 10/06/2014 10:56, Paul Carpenter wrote:

Wolfram Sang wrote:

quoted

On Tue, Jun 03, 2014 at 10:49:52AM +0200, Boris BREZILLON wrote:

quoted

The P2WI looks like an SMBus controller which only supports byte data
transfers. But, it differs from standard SMBus protocol on several
aspects:
- it supports only one slave device, and thus drop the address field
- it adds a parity bit every 8bits of data
- only one read access is required to read a byte (instead of a read
  followed by a write access in standard SMBus protocol)

Minor quibble should be
"(instead of a write followed by a read access in standard SMBus
  protocol)"

Fixed.

Thanks for pointing this out.

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com