Hi Joe,

On 06/09/2014 07:46 PM, Joe Perches wrote:

On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:

quoted

The driver is separated by functional parts. The core part
implements a platform driver probe and remove callbaks.
The probe enables clocks, checks crypto version, initialize
and request dma channels, create done tasklet and init
crypto queue and finally register the algorithms into crypto
core subsystem.

trivia:

quoted

diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h

[]

quoted

+#define AUTH_NONCE_NUM_WORDS_SHIFT	20
+#define AUTH_NONCE_NUM_WORDS_MASK	GENMASK(22, 20);

Unnecessary semicolon and appears to be unused.

Will correct, thanks.

It is unused because I dropped out AEAD support from this set. I plan to
add AEAD incrementally later on.

-- 
regards,
Stan