Re: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables
From: Daniel Thompson <hidden>
Date: 2014-06-02 10:15:49
Also in:
linux-arm-msm, linux-serial, lkml
On 01/06/14 14:38, Rickard Strandqvist wrote:
quoted hunk ↗ jump to hunk
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <redacted> --- drivers/tty/serial/msm_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 053b98e..c67f5c5 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c@@ -962,7 +962,7 @@ static int __init msm_console_setup(struct console *co, char *options) { struct uart_port *port; struct msm_port *msm_port; - int baud, flow, bits, parity; + int baud = 0, flow, bits, parity;
This made me wonder my "baud" is special compared to the other three variables. In fact I don't really think it is special so setting "baud" from the else clause in the uninitialized branch makes more sense to me.