Re: [PATCH v2 03/11] irqchip: versatile-fpga: add support for arm,versatile-sic
From: Linus Walleij <hidden>
Date: 2014-05-30 09:46:41
Also in:
linux-arm-kernel
On Fri, May 30, 2014 at 12:40 AM, Rob Herring [off-list ref] wrote:
From: Rob Herring <redacted> The secondary controller on ARM Versatile AB and PB is similar to other ARM platforms, but has a pass-thru register to connect some interrupts directly to interrupt inputs on the primary interrupt controller. The PIC_ENABLES register needs to be configured for proper operation when the matching node is arm,versatile-sic. Add the the necessary IRQCHIP_DECLARE as well. Signed-off-by: Rob Herring <redacted> Cc: Thomas Gleixner <redacted> Cc: Jason Cooper <redacted> Cc: Arnd Bergmann <redacted> --- v2: - Rework to use the compatible string for pass-thru register setup.
Nice!
quoted hunk
+ /* + * On Versatile AB/PB, some secondary interrupts have a direct + * pass-thru to the primary controller which need to be enabled. + */ + if (of_device_is_compatible(node, "arm,versatile-sic")) + writel(0xffd00000, base + PIC_ENABLES);
Maybe mention that we pass thru IRQs 20 and 22 thru 31 and why exactly these IRQs? Anyway: Acked-by: Linus Walleij <redacted> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html