Re: [PATCH 1/3] gpio: Add APM X-Gene SoC GPIO controller support
From: Linus Walleij <hidden>
Date: 2014-05-28 19:10:24
Also in:
linux-arm-kernel, linux-gpio
From: Linus Walleij <hidden>
Date: 2014-05-28 19:10:24
Also in:
linux-arm-kernel, linux-gpio
On Tue, May 27, 2014 at 6:59 PM, Feng Kan [off-list ref] wrote:
I will break out the gpio to separate device nodes as instructed, I will have to use the reg attribute to offset bank registers. Please let me know if it is acceptable.
Yeah sure regs = <a>, <b>, <c> for a single node is OK if that's what you mean.
gfc_gpio_fl0 GFC42'h1701c00c gfc_gpio_fl0_mux GFC42'h1701c010 gfc_gpio_fl1 GFC42'h1701c018 gfc_gpio_fl1_mux GFC42'h1701c01c gfc_gpio_fl2 GFC42'h1701c024 gfc_gpio_fl2_mux GFC42'h1701c028 gfc_gpio_fl0_od GFC42'h1701c030 gfc_gpio_fl1_od GFC42'h1701c034 gfc_gpio_fl2_od GFC42'h1701c038
Strange syntax in the last line there. GFC42'h uhm. But that looks a bit mingled actually. However I think you will be much happier if you split it into individual devices as I wanted to. It will be easier to maintain and simpler code even if the device tree may look a bit strange. Yours, Linus Walleij