Re: [PATCH v2] of/irq: provide int of_irq_parse_and_map_pci wrapper

On Friday, May 09, 2014 6:10 PM, Geert Uytterhoeven wrote:

On Fri, May 9, 2014 at 11:03 AM, Arnd Bergmann [off-list ref] wrote:

quoted

The pci-rcar driver is enabled for compile tests, and this has
now shown that the driver cannot build without CONFIG_OF,
following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
interrupt mapping when possible":

drivers/built-in.o: In function `rcar_pci_map_irq':
:(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'

As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
supposed to build fine, which we can achieve if we make the
declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
and provide an empty inline function otherwise, as we do for
a lot of other of interfaces.

This lets us build the rcar_pci driver again without CONFIG_OF
for build testing. All platforms using this driver select OF,
so this doesn't change anything for the users.

Thanks!

quoted

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Magnus Damm <redacted>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ben Dooks <redacted>
Cc: linux-pci@vger.kernel.org
Cc: linux-sh@vger.kernel.org

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Reviewed-by: Jingoo Han <redacted>

Best regards,
Jingoo Han