Thread (68 messages) 68 messages, 9 authors, 2014-06-20

Re: [RFC v2 01/10] arm: fiq: Allow EOI to be communicated to the intc

From: Russell King - ARM Linux <hidden>
Date: 2014-05-23 15:00:23
Also in: linux-arm-kernel, linux-serial

On Fri, May 23, 2014 at 02:57:49PM +0100, Daniel Thompson wrote:
+void eoi_fiq(int fiq)
+{
+	struct irq_data *irq_data = irq_get_irq_data(fiq + fiq_start);
+	struct irq_chip *chip = irq_data_get_irq_chip(irq_data);
+
+	if (chip->irq_eoi)
+			chip->irq_eoi(irq_data);
+}
So what if the IRQ chip takes a spinlock?  You can't take spinlocks in
FIQ context...  Who checks for that kind of stuff - just hoping that
the IRQ driver doesn't take a spinlock sounds real fragile.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help