Re: [PATCH net-next 2/4] net: systemport: use the new fixed PHY helpers
From: Thomas Petazzoni <hidden>
Date: 2014-05-19 20:19:46
Also in:
netdev
Dear Florian Fainelli, On Mon, 19 May 2014 12:43:43 -0700, Florian Fainelli wrote:
quoted hunk ↗ jump to hunk
+ priv->phydev = of_phy_connect(dev, priv->phy_dn, bcm_sysport_adj_link, + 0, priv->phy_interface); if (!priv->phydev) { netdev_err(dev, "could not attach to PHY\n"); return -ENODEV;@@ -1551,6 +1551,20 @@ static int bcm_sysport_probe(struct platform_device *pdev) if (priv->phy_interface < 0) priv->phy_interface = PHY_INTERFACE_MODE_GMII; + /* SYSTEMPORT uses the old 'fixed-link' 5-digit property which is + * deprecated, we need to register the fixed PHY using the Ethernet + * MAC node since we do not have a 'fixed-link' subnode. + */
Actually even if you use the new fixed PHY DT binding, the DT node linked to the PHY is the Ethernet MAC node. This is because I didn't want to have a difference between how things are handled between the old and the new binding. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com