Thread (1 message) 1 message, 1 author, 2014-05-13

Re: [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes

From: Geert Uytterhoeven <hidden>
Date: 2014-05-13 12:00:20
Also in: linux-sh

Hi Ben,

On Mon, Apr 14, 2014 at 11:35 PM, Ben Dooks [off-list ref] wrote:
quoted hunk
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -86,6 +88,76 @@
                };
        };

+       dma0: dma-mux@0 {
+               compatible = "renesas,shdma-mux";
+               #dma-cells = <2>;
+               dma-channels = <20>;
Shouldn't this be 30, i.e. the sum of the properties in the child nodes?
+               sysdma0: dma-controller@e6700000 {
+                       compatible = "renesas,shdma-r8a7790";
+                       clocks = <&mstp2_clks R8A7790_CLK_SYS_DMAC0>;
+                       dma-channels = <15>;
+               sysdma1: dma-controller@e6720000 {
+                       compatible = "renesas,shdma-r8a7790";
+                       clocks = <&mstp2_clks R8A7790_CLK_SYS_DMAC1>;
+                       dma-channels = <15>;
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help