Re: [PATCH v12 18/31] iommu/exynos: allow having multiple System MMUs for a master H/W
From: Tomasz Figa <hidden>
Date: 2014-05-06 18:05:33
Also in:
linux-arm-kernel, linux-iommu, linux-samsung-soc, lkml
On 27.04.2014 09:37, Shaik Ameer Basha wrote:
quoted hunk ↗ jump to hunk
From: Cho KyongHo <redacted> Some master device descriptor like fimc-is which is an abstraction of very complex H/W may have multiple System MMUs. For those devices, the design of the link between System MMU and its master H/W is needed to be reconsidered. A link structure, sysmmu_list_data is introduced that provides a link to master H/W and that has a pointer to the device descriptor of a System MMU. Given a device descriptor of a master H/W, it is possible to traverse all System MMUs that must be controlled along with the master H/W. Signed-off-by: Cho KyongHo <redacted> --- drivers/iommu/exynos-iommu.c | 545 ++++++++++++++++++++++++++---------------- 1 file changed, 335 insertions(+), 210 deletions(-)diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index fefedec3..c2e6365 100755 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c@@ -117,6 +117,10 @@ #define REG_PB1_EADDR 0x058 #define has_sysmmu(dev) (dev->archdata.iommu != NULL) +#define for_each_sysmmu_list(dev, list_data) \ + list_for_each_entry(list_data, \ + &((struct exynos_iommu_owner *)dev->archdata.iommu)->mmu_list, \ + entry)
Sorry, NAK. Please don't add this kind of complexity and business logic to low level code. We want the configuration functions to be simple, easy to read, maintain and extend. The proper way to do it is to let the IOMMUs be grouped together on IOMMU subsystem level, so that each IOMMU consumer driver would see just one IOMMU, but then IOMMU driver callbacks would handle just particular instances of the IOMMU IP blocks, without any loops, lists and other crazy code... Best regards, Tomasz