Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

On Tue, 2014-03-11 at 19:28 -0500, Vince Bridgers wrote:

Hi Joe,

On Tue, Mar 11, 2014 at 5:59 PM, Joe Perches [off-list ref] wrote:

quoted

On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:

quoted

This patch adds miscellaneous files for the Altera Ethernet Driver,
including ethtool support.

trivial notes:

quoted

diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c

[]

quoted

+static char const stat_gstrings[][ETH_GSTRING_LEN] = {

static const char

quoted

+     "aFramesTransmittedOK",

Why the prefix with a?

These names follow the names of the statistics found in the databook
for the Altera Triple Speed Ethernet (TSE) soft IP. I'm not
emotionally attached to these names, so will review the statistics
names and follow common usage instead. Thank you for noticing and
commenting.

[...]

These look like the statistic names specified in IEEE 802.3.  I would
support a general move to using standard names for MAC stats in Ethernet
drivers, because they are quite clearly defined and widely implemented
in hardware.  However, that is not the current practice in most Linux
drivers.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.