Re: Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem

On Tue, Mar 11, 2014 at 07:29:40PM +0000, Mark Brown wrote:

On Tue, Mar 11, 2014 at 08:24:11PM +0100, Carlo Caione wrote:

quoted

On Mon, Mar 03, 2014 at 10:56:16AM +0900, Mark Brown wrote:

quoted

quoted

quoted

+	regulators = of_find_node_by_name(np, "regulators");
+	if (!regulators) {
+		dev_err(&pdev->dev, "regulators node not found\n");
+		return -EINVAL;
+	}

quoted

quoted

The driver should be able to start up with no configuration provided at
all except for the device being registered - the user won't be able to
change anything but they will be able to read the current state of the
hardware which can be useful for diagnostics.

quoted

If the device is DT enabled and no configuration is provided for
regulators, these are disabled according to:

quoted

http://lxr.linux.no/linux+v3.13.5/drivers/regulator/core.c#L3797

quoted

Am I missing something or do you have any pointer?

With the above code the driver will return an error and never get as far
as registering the regulator.

I agree, but if I register the regulators without having the constrains
defined in the DT, when regulator_init_complete() is
called, the regulators are disabled powering off the SoC (at least for
DCDC2 and DCDC3).

Thanks,

-- 
Carlo Caione