On Wed, Feb 19, 2014 at 04:04:49PM +0000, Sebastian Capella wrote:

Quoting Lorenzo Pieralisi (2014-02-18 03:47:31)

quoted

+       - index
+               Usage: Required
+               Value type: <u32>
+               Definition: It represents the idle state index.
+                           An increasing index value implies less power
+                           consumption. Index must be given a sequential
+                           value = {0, 1, ....}, starting from 0.

One minor comment.  In the example, it can be tricky to see how this is sequential
since the states interleave.  Not sure if it merits rewording here?

- index
	Usage: Required
	Value type: <u32>
	Definition: It represents the idle state index.
		    The index must be given an increasing
		    value = {0, 1, ....}, starting from 0, with higher
		    values implying less power consumption.
		    Indices must be unique as seen from a cpu
		    perspective, ie phandles in the cpu nodes [1]
		    cpu-idle-states array property are not allowed to
		    point at idle state nodes having the same index
		    value.

Ack ?

I will post a v5, should be final.

Lorenzo