Re: [PATCH 1/3] dt-bindings: document gpio-charger bindings

Hi Rob,

Am Mittwoch, 12. März 2014, 09:28:46 schrieb Rob Herring:

On Wed, Mar 12, 2014 at 8:46 AM, Heiko Stübner [off-list ref] wrote:

quoted

From: Heiko Stuebner <redacted>

This documents the binding for the gpio-charger power-supply.

How does this relate to what's documented in power_supply.txt and
charger-manager.txt? Both have references to USB charging. Doesn't
this need some connection to a battery node?

Yep, the gpio-charger takes the position of the "some,usb-charger" from 
power_supply.txt .

       usb_charger: charger {
               compatible = "gpio-charger";
               charger-type = "usb-sdp";
               gpios = <&gpf0 2 0 0 0>;
       }

       battery {
               power-supplies = <&usb_charger>;
       };


I guess the binding doc could reflect this.


I haven't deeply looked into what charger-manager does, bit it seems to be a 
layer on top of chargers and batteries, controlling them. So it seems to be 
used with more intelligent components.

My setup using gpio-charger for example is vastly simpler, it's just a gpio 
reporting charger present (for gpio-charger), an adc reporting the battery 
voltage and another gpio reporting the charging state (which is already 
handled in generic-adc-battery, but needs a dt binding too).


Heiko

quoted

Signed-off-by: Heiko Stuebner <redacted>
---

 .../bindings/power_supply/gpio-charger.txt         | 23
 ++++++++++++++++++++++ 1 file changed, 23 insertions(+)
 create mode 100644
 Documentation/devicetree/bindings/power_supply/gpio-charger.txt> 
diff --git
a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt new
file mode 100644
index 0000000..fad87a4

--- /dev/null
+++ b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt

@@ -0,0 +1,23 @@
+gpio-charger
+
+Required properties :
+ - compatible : "gpio-charger"
+ - gpios : GPIO indicating the charger presence.
+   See GPIO binding in bindings/gpio/gpio.txt .
+ - charger-type : power supply type, one of
+     unknown
+     battery
+     ups
+     mains
+     usb-sdp (USB standard downstream port)
+     usb-dcp (USB dedicated charging port)
+     usb-cdp (USB charging downstream port)
+     usb-aca (USB accessory charger adapter)
+
+Example:
+
+       charger {
+               compatible = "gpio-charger";
+               charger-type = "usb-sdp";
+               gpios = <&gpf0 2 0 0 0>;
+       }
--

1.8.5.3