Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap

From
Matt Porter <hidden>
Date
2014-03-11 15:51:01
Also in
linux-arm-kernel, lkml
Reply to
Mark Brown, 2014-02-19
On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
quoted
+			csr_reg: regulator@13 {
+				reg = <13>;
+				regulator-compatible = "csr";
+				regulator-min-microvolt = <860000>;
+				regulator-max-microvolt = <1440000>;
+			};
You should not be setting voltage ranges like this in a .dtsi - you've
no idea if these voltage ranges are in fact valid for any given board so
they can't be set safely.  In general I would not expect to see any
configuration at all for regulators in an include file for the chip.
Agreed. I moved all constraints where they belong in the board-specific
dts.

Thanks,
Matt

Attachments

Thread (14 messages) 14 messages, 2 authors, last reply 2014-03-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help