Thread (11 messages) 11 messages, 4 authors, 2014-03-06

Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

From: Josh Cartwright <hidden>
Date: 2014-03-05 22:13:40
Also in: linux-arm-msm, linux-mmc, lkml

Hey Rob-

On Wed, Mar 05, 2014 at 12:56:22AM -0600, Rob Herring wrote:
On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov [off-list ref] wrote:
quoted
+- reg-names: Should contain the following:
+       "hc_mem"   - Host controller register map
+       "core_mem" - SD Core register map
reg-names should not be required and the order specified by the binding.
quoted
+- interrupts: Should contain an interrupt-specifiers for the interrupts listed in interrupt-names.
+- interrupt-names: Should contain the following:
+       "hc_irq"     - Host controller interrupt
+       "pwr_irq"    - PMIC interrupt
Same for interrupt-names.
Could you elaborate on this a bit?  I can understand not modifying an
existing binding to make {reg,interrupt}-names required, but for
completely new bindings, why is this a problem?

Not allowing a binding to require these properties renders
platform_get_{resource,irq}_byname() useless for drivers which
exclusively use DT for enumeration.  It also makes it impossible to make
a reg entry optional (although, there probably isn't a good usecase for
this).

Thanks,
  Josh

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help