Thread (9 messages) 9 messages, 4 authors, 2014-03-20

Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection

From: Sören Brinkmann <hidden>
Date: 2014-03-04 21:01:33
Also in: linux-mmc, lkml

On Tue, 2014-03-04 at 10:06PM +0200, Eli Billauer wrote:
Hello Sören,

wp-inverted solves the practical problem indeed, and fools the
driver into thinking that the card has an inverted write protection
sensor, and the logic zero that it finds in the hardware register
means that the card isn't write protected.

I'm insisting on this patch, because I think that the device tree
should describe the hardware as it is, and not fool the driver into
behaving the way we want it to. These tricks always bite back later
on.
Well, why is broken-wp more accurate than wp-inverted? Strictly
speaking the WP is there and working, it's just tied off to some value
you want to have interpreted the other way.
Anyway, seems like this is solvable with wp-inverted and whether the
additional quirk is needed I leave to others do decide.

	Sören
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help