Thread (4 messages) 4 messages, 3 authors, 2014-02-28

Re: [PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF

From: Arnd Bergmann <arnd@arndb.de>
Date: 2014-02-28 09:23:06
Also in: linux-arm-kernel

On Thursday 27 February 2014 19:27:03 Santosh Shilimkar wrote:
The of-dma.c is compiled out with !CONFIG_DMA_OF but the functions in
the header are kept under CONFIG_OF. Move them under CONFIG_OF_DMA
to avoid build errors with CONFIG_OFF && !CONFIG_DMA_OF

Cc: Grant Likely <redacted>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Santosh Shilimkar <redacted>
Sorry, but what is the problem you are seeing with this?

CONFIG_DMA_OF is defined as 'OF && DMAENGINE', and this code
should only be called from drivers that depend on DMAENGINE.

I'm not saying your patch is wrong, but you shouldn't need it
unless you do something very odd.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help