On 27-02-2014 20:06, Ben Dooks wrote:

quoted

Add support of the device tree probing for the Renesas R-Car generation 2 SoCs
documenting the device tree binding as necessary.

You've popped in some fixes for the driver probe in here as well.

    No, I didn't -- it's all the result of not using devm_clk_get().

[...]

quoted

@@ -177,13 +210,19 @@ static int rcar_gen2_usb_phy_probe(struc

[...]

quoted

-    clk = devm_clk_get(dev, "usbhs");
+    if (np)
+        clk = of_clk_get_by_name(np, "usbhs");
+    else
+        clk = clk_get(dev, "usbhs");

Can be removed, just add a clock-name of usbhs in the device node.

    Ah, I haven't figured out I should check clk_get() first... Yes, I'm 
adding the "clock-names" prop.

WBR, Sergei