Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix
From: David Woodhouse <dwmw2@infradead.org>
Date: 2014-02-19 12:59:03
Also in:
linux-arm-kernel
Possibly related (same subject, not in this thread)
- 2014-02-19 · Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix · Mark Rutland <mark.rutland@arm.com>
- 2014-02-19 · Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix · Ben Peddell <hidden>
- 2014-02-19 · Re: [PATCH v5 4/5] ARM: Kirkwood: Fix qnap vendor prefix · Andrew Lunn <hidden>
On Wed, 2014-02-19 at 22:49 +1000, klightspeed@killerwolves.net wrote:
Correct the vendor prefix for qnap, which should be the stock ticker symbol qnapsz.
No. This is an ABI change which appears to be gratuitous. Perhaps it's really necessary, and perhaps it's harmless because it won't *really* break compatibility with existing firmware because these boxes have *always* shipped with a DTB built into the kernel or something. In which case all I'm complaining about is the fact that you didn't properly address that in the commit comment and *explain* why it was OK... -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation