Re: [PATCH] mmc: omap_hsmmc: Add support for Erratum 2.1.1.128 in device tree boot
From: Nishanth Menon <nm@ti.com>
Date: 2014-02-14 05:48:54
Also in:
linux-arm-kernel, linux-mmc, linux-omap
From: Nishanth Menon <nm@ti.com>
Date: 2014-02-14 05:48:54
Also in:
linux-arm-kernel, linux-mmc, linux-omap
On 02/13/2014 05:05 PM, Tony Lindgren wrote:
* Nishanth Menon [off-list ref] [140205 06:15]:quoted
On Wed 05 Feb 2014 08:10:34 AM CST, Balaji T K wrote:quoted
quoted
quoted
Rather than ti,errata.. specific property, something like caps no/disable multiblock read is more readable in my opinion, OtherwiseIs'nt the better definition to state i have quirk X and allow the driver to do the necessary thing/things needed to handle quirk X? in this case, there is just one thing to do: broken multi_block_read, in the case of other quirks, there might be more than 1 thing to do.. let driver figure that out, dts just states the h/w capabilty or in this case, the quirk capability.But in this case there is only one. disable multi block read is more readable than the errata reference, No strong feelings though.Considering this might set an precedence for other quirk description, I'd like to leave it as it stands.Hmm if this really depends on the hardware version, how about just add new compatible flag ti,omap3430-rev-xyz-hsmmc that allows the driver to deal with the errata?
yep - that is a very good idea. updated v2 series tested and posted: http://marc.info/?l=linux-omap&m=139235682727541&w=2 https://patchwork.kernel.org/patch/3650061/ https://patchwork.kernel.org/patch/3650031/ -- Regards, Nishanth Menon