Re: [RFC PATCH v2 02/21] drm/exynos: delay fbdev initialization until an output is connected
From: Sachin Kamat <hidden>
Date: 2014-02-12 12:03:56
Also in:
dri-devel, linux-samsung-soc
+cc Inki Dae Looks like you missed CCing Exynos DRM maintainers. On 12 February 2014 17:01, Andrzej Hajda [off-list ref] wrote:
In case fbdev is initialized before any output is connected, fb resolution defaults to 1024x768. After that any output with bigger resolution is ignored and fbdev is not displayed. The patch postpones fbdev initialization to avoid such situation. Signed-off-by: Andrzej Hajda <redacted> ---
[snip]
quoted hunk ↗ jump to hunk
static const struct drm_mode_config_funcs exynos_drm_mode_config_funcs = {diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index e7c2f2d..9a5ec83 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c@@ -249,8 +249,10 @@ int exynos_drm_fbdev_init(struct drm_device *dev) return 0; fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); - if (!fbdev) + if (!fbdev) { + DRM_ERROR("failed to allocate fbdev.\n");
This message is not needed as kzalloc gives oom message.
return -ENOMEM; + }
-- With warm regards, Sachin