Re: [RFC/PATCH 1/1] mtd: nand: Add a devicetree binding for ECC strength and ECC step size

Hi Gupta,

On 11/02/2014 16:49, Gupta, Pekon wrote:

Hi Ezequiel,

quoted

From: Ezequiel Garcia [mailto:ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org]

quoted

diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
index 03855c8..683a310 100644
--- a/Documentation/devicetree/bindings/mtd/nand.txt
+++ b/Documentation/devicetree/bindings/mtd/nand.txt

@@ -3,5 +3,9 @@
  - nand-ecc-mode : String, operation mode of the NAND ecc mode.
    Supported values are: "none", "soft", "hw", "hw_syndrome", "hw_oob_first",
    "soft_bch".

Should nand-ecc-mode also be marked as <deprecated>, and but we continue
supporting it in kernel code ? If yes, then what is the life-time of these
<deprecated> bindings. I mean exactly how many kernel versions should
continue support deprecated bindings ?

What do you mean by deprecated ? How would a NAND flash controller driver choose amongs
its supported NAND ecc modes if we remove this property ?

Is there another patch series removing this property in the wild ?

quoted

quoted

+- nand-ecc-strength : integer ECC required strength.

With recent patches from 'Boris BREZILLON [off-list ref]'
"[RFC PATCH] mtd: add per NAND partition ECC config"
Would you like 'nand-ecc-strength' to be per partition based ?

I don't think we should rely on this for the moment: I'm still working on it but it's far from stable.

Moreover, we can keep a default ecc mode for the NAND chip and partitions will inherit this ECC
mode when they do not specify any specific ECC config.

Best Regards,

Boris

with regards, pekon

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html