Re: [alsa-devel] [PATCH] ASoC: pcm512x: Add PCM512x driver

On Thu, Feb 06, 2014 at 01:51:33PM +0100, Takashi Iwai wrote:

Mark Brown wrote:

quoted

+static const char *pcm512x_dsp_program_texts[] = {

The numbers of items in pcm512x_dsp_program_texts[] and _values[]
don't match.

Yeah, fixed.

quoted

+static const struct soc_enum pcm512x_clk_missing =
+	SOC_ENUM_SINGLE(PCM512x_CLKDET, 0,  7, pcm512x_clk_missing_text);

Isn't it 8?

Hrm, it is but this points out an error in the control helpers which has
been there since forever - they call that parameter max but it's not a
maximum, it's the number of elements in the enumeration.  I bet we have
a bunch of other enumerations which miss the last element as a result.