Re: [PATCHv10] video: backlight: gpio-backlight: Add DT support.

On Thursday, January 16, 2014 10:19 PM, Denis Carikli wrote:

Cc: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
Cc: Eric Bénard <redacted>
Cc: Grant Likely <redacted>
Cc: Ian Campbell <redacted>
Cc: Jean-Christophe Plagniol-Villard <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Jingoo Han <redacted>
Cc: Kumar Gala <redacted>
Cc: Laurent Pinchart <Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
Cc: Lothar Waßmann <redacted>
Cc: Mark Rutland <redacted>
Cc: Pawel Moll <redacted>
Cc: Rob Herring <redacted>
Cc: Thierry Reding <redacted>
CC: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Denis Carikli <redacted>
---
ChangeLog v9->v10:
- Only the respective maintainers, or people who responded to the patch
  were kept in the Cc.
- The unnecessary of_match_ptr in of_match_table was removed.

ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property,
  the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.

ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm,
  That way we avoid having to handle the case where it's not set,
  which means that we would need not to set the gpio, but still
  report a brightness value for sysfs, when not all gpio controllers are
  able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead
  of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then
  dropped, becuase it is not necessary anymore.

ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.

ChangeLog v5->v6:
- The default state handling was reworked:
  - it's now called default-state, and looks like the gpio-leds default-state.
  - it now has a "keep" option, like for the gpio-leds.
  - that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.

ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.
---
 .../bindings/video/backlight/gpio-backlight.txt    |   19 +++++++
 drivers/video/backlight/gpio_backlight.c           |   60 +++++++++++++++++---
 2 files changed, 72 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt

[.....]

[.....]

+static struct of_device_id gpio_backlight_of_match[] = {
+	{ .compatible = "gpio-backlight" },
+	{ /* sentinel */ }
+};
+
 static struct platform_driver gpio_backlight_driver = {
 	.driver		= {
 		.name		= "gpio-backlight",
 		.owner		= THIS_MODULE,
+		.of_match_table = &gpio_backlight_of_match,

The following build warning happens.
Would you fix the following build error?

CC      drivers/video/backlight/gpio_backlight.o
drivers/video/backlight/gpio_backlight.c:162:3: warning: initialization from incompatible pointer type [enabled by default]
drivers/video/backlight/gpio_backlight.c:162:3: warning: (near initialization for ?쁤pio_backlight_driver.driver.of_match_table?? [enabled by default]


Best regards,
Jingoo Han

 	},
 	.probe		= gpio_backlight_probe,
 };
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html