Re: [PATCH 1/2] devicetree: Add devicetree bindings documentation for the ADAU1977

On 02/03/2014 04:15 PM, Geert Uytterhoeven wrote:

On Mon, Feb 3, 2014 at 3:57 PM, Lars-Peter Clausen [off-list ref] wrote:

quoted

+ - adi,micbias: Configures the voltage setting for the MICBIAS pin. If not
+   specified the default value will be 8.5 Volts. This property is only valid
+   for the ADAU1977.
+   Valid values for this property are:
+       0: 5.0V
+       1: 5.5V
+       2: 6.0V
+       3: 6.5V
+       4: 7.0V
+       5: 7.5V
+       6: 8.0V
+       7: 8.5V
+       8: 9.0V

This means the casual DTS reader need to know about the meaning of
the values. You can avoid that by:
   1. Using preprocessor defines. Drawback is that you have to add an
      include file.
   2. Using mV, and specify minimum, maximum, and incrementals in the
      bindings, cfr.
Documentation/devicetree/bindings/power_supply/ti,bq24735.txt
      Drawback is that the user can easily specify invalid values.

Is there a preference for either of them?

Thanks,
- Lars

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html