Re: [PATCH] of: fix PCI bus match for PCIe slots
From: Rob Herring <hidden>
Date: 2014-02-01 22:54:06
On Thu, Jan 30, 2014 at 5:29 PM, Kleber Sacilotto de Souza [off-list ref] wrote:
On IBM pseries systems the device_type device-tree property of a PCIe bridge contains the string "pciex". The of_bus_pci_match() function was looking only for "pci" on this property, so in such cases the bus matching code was falling back to the default bus, causing problems on functions that should be using "assigned-addresses" for region address translation. This patch fixes the problem by also looking for "pciex" on the PCI bus match function.
Does this need to go to stable?
quoted hunk
Signed-off-by: Kleber Sacilotto de Souza <redacted> --- drivers/of/address.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/of/address.c b/drivers/of/address.c index d3dd41c..0da2c0f 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c@@ -102,8 +102,8 @@ static int of_bus_pci_match(struct device_node *np) * "vci" is for the /chaos bridge on 1st-gen PCI powermacs * "ht" is hypertransport
How about a comment for who needs pciex.
*/ - return !strcmp(np->type, "pci") || !strcmp(np->type, "vci") || - !strcmp(np->type, "ht"); + return !strcmp(np->type, "pci") || !strcmp(np->type, "pciex") || + !strcmp(np->type, "vci") || !strcmp(np->type, "ht"); } static void of_bus_pci_count_cells(struct device_node *np, -- 1.7.1
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html