Thread (8 messages) 8 messages, 4 authors, 2014-02-26

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

From: Andy Gross <hidden>
Date: 2014-02-26 17:07:00
Also in: linux-arm-kernel, linux-arm-msm, lkml

On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote:
quoted
+	/* read revision and configuration information */
+	val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK;
+
The ees shit is not zero and you got wrong ee. Could you add the line
below or something similar:

val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK;
Good catch.  I missed the shift when I reworked and got lucky that the revision
is in the lower 8 bits and is non-zero.

-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help