RE: [PATCH v2 1/3] usb: chipidea: msm: Add device tree binding information

Hi,

On Wed, 2014-02-19 at 09:46 -0800, Courtney Cavin wrote:

quoted

On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote:

quoted

Hi,

On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote:

quoted

On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote:

quoted

From: "Ivan T. Ivanov" <redacted>

Document device tree binding information as required by the
Qualcomm USB controller.

Signed-off-by: Ivan T. Ivanov <redacted>
---
 .../devicetree/bindings/usb/msm-hsusb.txt          |   17

+++++++++++++++++

quoted

quoted

quoted

Although you mentioned to Josh that this is intended for "non-

standard"

quoted

quoted

quoted

Chipidea properties, I don't see any other than requiring that

'dr_mode'

quoted

quoted

quoted

must be "peripheral".  It would seem that this should all be
integrated into a ci3xxx.txt.

Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt.
So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt?

Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved
to ci-hdrc-imx.txt.  I was recommending to merge the two into one
'ci13xxx.txt', as this binding seems to be a new compatible for the
same basic chip.  Now perhaps 'ci-hdrc.txt'.

Although I agree with Josh that this name should be changed, and I
think either of your two suggestions would be acceptable, I would like
to at least discuss the possibility of actually merging the two in
this series.

Comments?

iMX version have required and recommender properties which are not
meaningful for QCOM variant. I will prefer separate file. It depends on
Freescale engineers (now in Cc:)

Unlike dwc3, there is no common dts entry for chipidea core, every platform
uses its own dts to cover both common and platform-specific properties.

I also have plan to use dwc3 style way for dts, but msm platform has still
not used dts, I don't know how many msm platforms need to change, once
you finish transferring msm to dts, I will split common and platform specific
entry.

Peter

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html