Re: [PATCHv1 5/6] HSI: Introduce OMAP SSI driver
From: Nishanth Menon <nm@ti.com>
Date: 2014-02-24 15:57:35
Also in:
linux-omap, lkml
On 02/24/2014 09:51 AM, Mark Rutland wrote:
On Sun, Feb 23, 2014 at 11:50:00PM +0000, Sebastian Reichel wrote:
[...]
quoted
+static int omap_ssi_port_runtime_suspend(struct device *dev) +{ + struct hsi_port *port = dev_get_drvdata(dev); + struct omap_ssi_port *omap_port = hsi_port_drvdata(port); + struct hsi_controller *ssi = to_hsi_controller(port->device.parent); + struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi); + + dev_dbg(dev, "port runtime suspend!\n"); + + ssi_set_port_mode(omap_port, SSI_MODE_SLEEP); + if (omap_ssi->get_loss) + omap_port->loss_count = + (*omap_ssi->get_loss)(ssi->device.parent);You don't need to do (*struct->func)(args) when invoking a function pointer. You can jsut have struct->func(args) as we do elsewhere. This can be: omap_ssi->get_loss(ssi->device.parent) This should be fixed up in the other sites too.
in fact, we should stop expecting that service and drivers should manage their own context_loss detection Examples: MMC: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0a82e06e6183a252608df48cc4793b83e2d73dfd DSS: http://marc.info/?l=linux-omap&m=139272358619064&w=2 -- Regards, Nishanth Menon