Thread (6 messages) 6 messages, 3 authors, 2014-06-29

Re: [PATCH 1/2] staging: iio: hmc5843: Add all available models to device tree id table.

flat view

From: Jonathan Cameron <hidden>
Date: 2014-02-18 10:40:16
Also in: linux-iio, lkml

On 14/02/14 14:25, Marek Belisko wrote:
Signed-off-by: Marek Belisko <redacted>
I wonder how this got missed.  However, for those data elements to be useful, you will
need to read them somewhere in the driver I think.... (if there is any magic
that puts this in the relevant i2c locations then point it out to me!)
quoted hunk ↗ jump to hunk
---
  drivers/staging/iio/magnetometer/hmc5843.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
index d4f4dd9..f595fdc 100644
--- a/drivers/staging/iio/magnetometer/hmc5843.c
+++ b/drivers/staging/iio/magnetometer/hmc5843.c
@@ -630,7 +630,9 @@ static const struct i2c_device_id hmc5843_id[] = {
  MODULE_DEVICE_TABLE(i2c, hmc5843_id);

  static const struct of_device_id hmc5843_of_match[] = {
-	{ .compatible = "honeywell,hmc5843" },
+	{ .compatible = "honeywell,hmc5843", .data = (void *)HMC5843_ID },
+	{ .compatible = "honeywell,hmc5883", .data = (void *)HMC5883_ID },
+	{ .compatible = "honeywell,hmc5883l", .data = (void *)HMC5883L_ID },
  	{}
  };
  MODULE_DEVICE_TABLE(of, hmc5843_of_match);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help