Thread (3 messages) 3 messages, 3 authors, 2014-02-12

Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32

flat view

From: Guenter Roeck <hidden>
Date: 2014-02-11 20:20:45
Also in: linux-arm-kernel, linux-watchdog, lkml

On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote:
Use of_property_read_u32 functions to clean probe function.

Signed-off-by: Michal Simek <redacted>
---
[ ... ]
quoted hunk ↗ jump to hunk
+
+	if (enable_once)
 		watchdog_set_nowayout(xilinx_wdt_wdd, true);
-	}
	watchdog_set_nowayout(xilinx_wdt_wdd, enable_once);

would probably do as well (the function checks the flag as well).

Nitpick, so

Reviewed-by: Guenter Roeck <redacted>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help