Thread (31 messages) 31 messages, 5 authors, 2014-02-11

Re: [PATCH 2/2] spi: Add Qualcomm QUP SPI controller support

From: Josh Cartwright <hidden>
Date: 2014-02-07 17:50:09
Also in: linux-arm-msm, linux-spi, lkml

On Fri, Feb 07, 2014 at 05:31:08PM +0000, Mark Brown wrote:
On Fri, Feb 07, 2014 at 11:20:51AM -0600, Josh Cartwright wrote:
quoted
On Fri, Feb 07, 2014 at 05:18:34PM +0000, Mark Brown wrote:
quoted
On Fri, Feb 07, 2014 at 10:51:27AM -0600, Josh Cartwright wrote:
quoted
	config SPI_QUP
		tristate "Qualcomm SPI Support with QUP interface"
		depends on OF
		depends on ARM
quoted
quoted
Does this really depend on ARM?  If so why?
quoted
The ARM dependency is there for the use of _relaxed io accessor
variants.
That's not ARM only and I thought we were getting generic versions of it
anyway?  ARMv8, MIPS, Microblaze, Hexagon and SH also define it.
Okay, that's fair.  I'm only vaguely familiar with the generic _relaxed
variants, but until they land, how do we appropriately declare the
dependency to prevent breaking COMPILE_TEST builds on architectures that
don't have them?  Or should we either bother?

Do we need to introduce a HAVE_RELAXED_IO_ACCESSORS selected by those
architectures with support?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help