Re: [PATCH v5 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

Hi Tomasz,

Thanks for the review.
Will consider all your comments in the next version of patch series.

Regards,
Shaik Ameer Basha

On Sat, Jan 25, 2014 at 1:09 AM, Tomasz Figa [off-list ref] wrote:

Hi Shaik,


On 09.01.2014 04:28, Shaik Ameer Basha wrote:

quoted

This patch adds the DT binding documentation for the
Exynos5420/5410 based SCALER device driver.

Signed-off-by: Shaik Ameer Basha <redacted>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
  .../devicetree/bindings/media/exynos5-scaler.txt   |   22
++++++++++++++++++++
  1 file changed, 22 insertions(+)
  create mode 100644
Documentation/devicetree/bindings/media/exynos5-scaler.txt

diff --git a/Documentation/devicetree/bindings/media/exynos5-scaler.txt

b/Documentation/devicetree/bindings/media/exynos5-scaler.txt
new file mode 100644
index 0000000..9328e7d

--- /dev/null
+++ b/Documentation/devicetree/bindings/media/exynos5-scaler.txt

@@ -0,0 +1,22 @@
+* Samsung Exynos5 SCALER device
+
+SCALER is used for scaling, blending, color fill and color space
+conversion on EXYNOS[5420/5410] SoCs.
+
+Required properties:
+- compatible: should be "samsung,exynos5420-scaler" or
+                       "samsung,exynos5410-scaler"
+- reg: should contain SCALER physical address location and length
+- interrupts: should contain SCALER interrupt number

s/number/specifier/

quoted

+- clocks: should contain the SCALER clock specifier, from the
+                       common clock bindings

s/specifier/phandle and specifier pair for each clock listed in clock-names
property/

s/from/according to/

quoted

+- clock-names: should be "scaler"

should contain exactly one entry:
 - "scaler" - IP bus clock.

Also this patch should be first in the series to let the driver added in
further patches use already present bindings.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
in

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html