Re: [PATCH] phy-rcar-usb-gen2: add device tree support
From: Sergei Shtylyov <hidden>
Date: 2014-01-27 18:23:50
Also in:
linux-sh
Possibly related (same subject, not in this thread)
- 2014-01-29 · Re: [PATCH] phy-rcar-usb-gen2: add device tree support · Simon Horman <hidden>
- 2014-01-29 · Re: [PATCH] phy-rcar-usb-gen2: add device tree support · Sergei Shtylyov <hidden>
- 2014-01-29 · Re: [PATCH] phy-rcar-usb-gen2: add device tree support · Simon Horman <horms@verge.net.au>
- 2014-01-29 · Re: [PATCH] phy-rcar-usb-gen2: add device tree support · Sergei Shtylyov <hidden>
- 2014-01-29 · Re: [PATCH] phy-rcar-usb-gen2: add device tree support · Simon Horman <hidden>
Hello. On 01/26/2014 08:05 PM, Ben Dooks wrote:
Add support for the phy-rcar-gen2-usb driver to be probed from device tree.
Signed-off-by: Ben Dooks <redacted> Reviewed-by: Ian Molton <redacted> --- Fixes from v2: - fix missing of_if patch (I clearly should not be let near git-rebase when hungry)
Fixes from v1: - use of_property_reasd-bool() - remove unused of_id variable
Cc: linux-usb@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Simon Horman <horms@verge.net.au> Cc: devicetree@vger.kernel.org --- drivers/usb/phy/phy-rcar-gen2-usb.c | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c index db3ab34..e4665b9 100644 --- a/drivers/usb/phy/phy-rcar-gen2-usb.c +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
[...]
quoted hunk ↗ jump to hunk
@@ -167,6 +168,12 @@ out: spin_unlock_irqrestore(&priv->lock, flags); } +static struct of_device_id rcar_gen2_usb_phy_ofmatch[] = { + { .compatible = "renesas,usb-phy-r8a7790", }, + { .compatible = "renesas,rcar-gen2-usb-phy", },
Frankly speaking, I don't understand the need for the clearly duplicate
entries.
WBR, Sergei