Re: [PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors
From: Sergei Shtylyov <hidden>
Date: 2014-01-22 20:46:11
Also in:
linux-arm-kernel
Hello. On 01/22/2014 10:32 PM, Hans de Goede wrote:
Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings, see: Documentation/devicetree/bindings/usb/usb-ehci.txt
Signed-off-by: Hans de Goede <redacted>
[...]
quoted hunk
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c index b2d0e1e..71e9d8e 100644 --- a/drivers/usb/host/ohci-platform.c +++ b/drivers/usb/host/ohci-platform.c
[...]
quoted hunk
@@ -164,8 +165,34 @@ static int ohci_platform_probe(struct platform_device *dev)
[...]
+#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
+ if (ohci->flags & OHCI_QUIRK_BE_MMIO) {
+ dev_err(&dev->dev,
+ "Error big-endian-regs not compiled in\n");
+ err = -EINVAL;
+ goto err_put_hcd;
+ }
+#endif
+#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_DESC
+ if (ohci->flags & OHCI_QUIRK_BE_DESC) {
+ dev_err(&dev->dev,
+ "Error big-endian-desc not compiled in\n");
Small grammar nits (sorry): some punctuation like comma or semicolon
wouldn't hurt after "Error" word here and above. The same for ehci-platfrom.c.
Also, "support" word wouldn't hurt after the property names in the same message.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html