Re: [PATCH 1/2] ohci-platform: Add support for controllers with big-endian regs / descriptors

On Tue, 21 Jan 2014, Hans de Goede wrote:

Hi,

On 01/21/2014 05:40 PM, Alan Stern wrote:

quoted

On Tue, 21 Jan 2014, Hans de Goede wrote:

quoted

Note this commit uses the same devicetree booleans for this as the ones
already existing in the usb-ehci bindings.

Signed-off-by: Hans de Goede <redacted>

quoted

--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig

@@ -512,6 +512,10 @@ config USB_CNS3XXX_OHCI

  config USB_OHCI_HCD_PLATFORM
  	tristate "Generic OHCI driver for a platform device"
+	# Always support LE, support BE on architectures which have readl_be
+	select USB_OHCI_LITTLE_ENDIAN
+	select USB_OHCI_BIG_ENDIAN_DESC if (AVR32 || MIPS || MICROBLAZE || SPARC || PPC32 || PPC64)
+	select USB_OHCI_BIG_ENDIAN_MMIO if (AVR32 || MIPS || MICROBLAZE || SPARC || PPC32 || PPC64)
  	default n

quoted

In any case, the style we have adopted is that these select lines go in
the arch-specific defconfig, not here.

Ok, so I should drop the Kconfig parts of both patches ?

That's rigt.  They are likely to cause trouble, and if the selects were
needed then they should already be present somewhere else.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html