Re: [PATCH v3 1/2] i2c: qup: Add device tree bindings information
From: Stephen Boyd <hidden>
Date: 2014-01-21 02:40:07
Also in:
linux-arm-kernel, linux-arm-msm, linux-i2c
On 01/20, Rob Herring wrote:
On Fri, Jan 17, 2014 at 5:03 PM, Bjorn Andersson [off-list ref] wrote:quoted
.../devicetree/bindings/i2c/qcom,i2c-qup.txt | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txtdiff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt new file mode 100644 index 0000000..a99711b --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt@@ -0,0 +1,41 @@ +Qualcomm Universal Peripheral (QUP) I2C controller + +Required properties: + - compatible: Should be "qcom,i2c-qup".Seems a bit generic. All versions of the IP are exactly the same? "qcom,<chip>-i2c-qup" would be better.
There are different versions of the IP in different SoCs. The versions for platforms supported upstream are: 1.1.1 (MSM8660, MSM8960) 2.2.1 (MSM8974v2) so how about one of "qcom,i2c-qup-v1.1.1" or "qcom,i2c-qup-v2.2.1" should be specified as more specific compatible strings in addition to "qcom,i2c-qup"? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation