Re: [PATCH 2/3] mmc: dw_mmc: call mmc_of_parse to fill in common options
From: Jaehoon Chung <jh80.chung@samsung.com>
Date: 2014-01-20 04:53:10
Also in:
linux-arm-kernel, linux-mmc
Hi, Olof. It looks good to me. When use the mmc_of_parse, we can also remove the duplicated property. I have also worked the patch for using mmc_of_parse(). 1. caps2-mmc-hs200-1_8v/1_2v capability can be moved into mmc_of_parse. then we can remove parsing of dt into dw_mmc.c 2. keep-power-in-suspend/enable-sdio-wakeup can be removed. If i missed other patch, let me know, plz. how about? if you're ok, i will send the patch-set on this week. Best Regards, Jaehoon Chung On 01/20/2014 12:56 PM, Olof Johansson wrote:
quoted hunk ↗ jump to hunk
The shared of parse function fills in common options for capabilities, etc, but it needs to be called from each driver that wants to make use of it. dw_mmc was missing the call. Signed-off-by: Olof Johansson <redacted> --- drivers/mmc/host/dw_mmc.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a776f24..7119f63 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c@@ -2137,6 +2137,8 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) if (!mmc) return -ENOMEM; + mmc_of_parse(mmc); + slot = mmc_priv(mmc); slot->id = id; slot->mmc = mmc;