Re: [RFC v3 04/13] ahci-platform: Undo pdata->resume on resume failure

Hi,

On 01/19/2014 08:13 PM, Tejun Heo wrote:

Hello,

On Sun, Jan 19, 2014 at 07:40:21PM +0100, Hans de Goede wrote:

quoted

That sounds like your advocating for just returning from resume on the
first error without undoing any of the previous steps, have I gotten that
right?

Yeah, or just ignore reset failure and proceed.

That seems like a bad idea IMHO, if reset failed something is seriously
amiss and just continuing as nothing happened seems unhelpful.

quoted

That sounds as sensible as any other approach on resume errors
(there are IMHO no good answers), if that is what you mean, shall I do a

Suspending back is the wrong answer tho.

quoted

patch in the next versions of my patch-set doing that ?

Isn't just dropping this patch enough tho?

Well the current error handling still re-disables the clks on resume failure,
if you want to proceed with resume as far as possible, rather then return to
a suspended state it seems sensible to just leave the clocks on as well.

Also disabling the clocks on resume failure, followed by a rmmod will cause
a WARN_ON to trigger in the clock-framework when ahci_host_stop tries to
disable the clks for a second time.

Regards,

Hans