Re: [PATCH v2 1/4] libahci: Add a pre ahci_start_engine hook
From: Tejun Heo <hidden>
Date: 2014-01-12 12:06:54
Also in:
linux-arm-kernel, linux-ide
Hello, On Sat, Jan 04, 2014 at 10:14:35AM +0100, Hans de Goede wrote:
quoted hunk
@@ -323,6 +323,8 @@ struct ahci_host_priv { u32 em_msg_type; /* EM message type */ struct clk *clk; /* Only for platforms supporting clk */ void *plat_data; /* Other platform data */ + /* Optional pre ahci_start_engine hook */ + void (*pre_start_engine)(struct ata_port *ap);
I'd much prefer if the callback overrides start_engine itself rather than adding a hook inside start_engine. This is a bit too specific. Thanks. -- tejun