Re: [PATCH v2 2/4] ARM: sunxi: Add ahci-sunxi driver for the Allwinner SUNXi SoCs sata

On Saturday 04 January 2014 22:39:50 Arnd Bergmann wrote:

quoted

+Required properties:
+- compatible : compatible list, contains "allwinner,sun4i-a10-ahci"
+- reg                : <registers mapping>
+- interrupts : <interrupt mapping for AHCI IRQ>
+- clocks     : clocks for ACHI
+- clock-names        : clock names for AHCI

The binding needs to specify the required names for the clocks.

fwiw, the imx driver uses "ahb" and "sata_ref" as the clock names.
I would strongly suggest using the same names here, and documenting
them in the ahci binding as optional.

	Arnd