Re: [PATCH 01/11] dt: binding: add binding for ImgTec IR block
From: Tomasz Figa <hidden>
Date: 2013-12-22 12:48:43
Also in:
linux-media
Hi James, On Friday 13 of December 2013 15:12:49 James Hogan wrote:
quoted hunk ↗ jump to hunk
Add device tree binding for ImgTec Consumer Infrared block. Signed-off-by: James Hogan <redacted> Cc: Mauro Carvalho Chehab <redacted> Cc: linux-media@vger.kernel.org Cc: Rob Herring <redacted> Cc: Pawel Moll <redacted> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Stephen Warren <redacted> Cc: Ian Campbell <redacted> Cc: devicetree@vger.kernel.org Cc: Rob Landley <redacted> Cc: linux-doc@vger.kernel.org --- Documentation/devicetree/bindings/media/img-ir.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/img-ir.txtdiff --git a/Documentation/devicetree/bindings/media/img-ir.txt b/Documentation/devicetree/bindings/media/img-ir.txt new file mode 100644 index 000000000000..6f623b094ea6 --- /dev/null +++ b/Documentation/devicetree/bindings/media/img-ir.txt@@ -0,0 +1,20 @@ +* ImgTec Infrared (IR) decoder + +Required properties: +- compatible: Should be "img,ir"
This compatible string isn't really very specific. Is there some IP revision string that could be added, to account for possible design changes that may require binding change?
+- reg: Physical base address of the controller and length of + memory mapped region. +- interrupts: The interrupt specifier to the cpu. + +Optional properties: +- clocks: Clock specifier for base clock. + Defaults to 32.768KHz if not specified.
To make the binding less fragile and allow interoperability with non-DT platforms it may be better to provide also clock-names property (so you can use clk_get(); that's a Linux implementation detail, though, but to make our lives easier IMHO they should be sometimes considered too). Best regards, Tomasz